Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump babel to ^7.21.4 #36815

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Bump babel to ^7.21.4 #36815

merged 4 commits into from
Apr 28, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 9, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@babel/code-frame (source) ^7.18.6 -> ^7.21.4 age adoption passing confidence
@babel/core (source) ^7.21.3 -> ^7.21.4 age adoption passing confidence
@babel/helper-module-imports (source) ^7.18.6 -> ^7.21.4 age adoption passing confidence
@babel/plugin-syntax-jsx (source) ^7.18.6 -> ^7.21.4 age adoption passing confidence
@babel/plugin-transform-runtime (source) ^7.21.0 -> ^7.21.4 age adoption passing confidence
@babel/preset-env (source) ^7.20.2 -> ^7.21.4 age adoption passing confidence
@babel/preset-typescript (source) ^7.21.0 -> ^7.21.4 age adoption passing confidence
@babel/traverse (source) ^7.21.3 -> ^7.21.4 age adoption passing confidence
@babel/types (source) ^7.21.3 -> ^7.21.4 age adoption passing confidence

Release Notes

babel/babel

v7.21.4

Compare Source

🐛 Bug Fix
  • babel-core, babel-helper-module-imports, babel-preset-typescript
  • babel-generator
💅 Polish
  • babel-helper-create-class-features-plugin, babel-plugin-proposal-class-properties, babel-plugin-transform-typescript, babel-traverse
🏠 Internal

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Apr 9, 2023
@mui-bot
Copy link

mui-bot commented Apr 9, 2023

Netlify deploy preview

https://deploy-preview-36815--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against fc63e44

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Apr 10, 2023

I think the PR babel/babel#15427 retains the comments of TypeScript types in the output JS files, which causes an issue for us (See this PR's CI failure) where the comments for the types should not be added in the JS files when transforming. It is irrelevant in the output.

Related Babel issue - babel/babel#9916 for babel/babel#15427.

I have raised the concern in babel/babel#15427 (comment) and babel/babel#15579.

@renovate
Copy link
Contributor Author

renovate bot commented Apr 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mui/core Regarding the above issue, I have added a tag @babel-ignore-comment-in-output to let babel identify and ignore that comment in the JS file. Please check.

Related babel issue - babel/babel#15579

@ZeeshanTamboli ZeeshanTamboli requested review from a team April 24, 2023 05:44
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 26, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit 48a0169 into master Apr 28, 2023
21 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the renovate/babel branch April 28, 2023 11:10
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants