Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bandit.HTTP1.Adapter.inform/3 return value #268

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fix Bandit.HTTP1.Adapter.inform/3 return value #268

merged 2 commits into from
Jan 16, 2024

Commits on Nov 22, 2023

  1. Fix Bandit.HTTP1.Adapter.inform/3 return value 

    Per https://hexdocs.pm/plug/Plug.Conn.Adapter.html#c:inform/3, the
callback should return:

    :ok | {:error, :not_supported}

The way Plug.Conn.inform! is implemented at the moment,
https://github.com/elixir-plug/plug/blob/v1.15.2/lib/plug/conn.ex#L1335,
it looked like Bandit did _not_ implement inform but it sure does!
    @wojtekmach
    wojtekmach committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    18e12ed View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Update

    @wojtekmach
    wojtekmach committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    5645795 View commit details
    Browse the repository at this point in the history