Update ruff configuration to fix deprecation warnings. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruff has deprecated top-level lint settings, instead they must be moved into a dedicated `lint` section. Additionally, the CLI now needs to be invoked with a `check` subcommand. https://astral.sh/blog/ruff-v0.2.0#configuration-changes astral-sh/ruff#10169
richfitz
approved these changes
Apr 9, 2024
|
Not sure why the windows test is failing here; unrelated to these changes. Is this something that fails sometimes perhaps (e.g., timing difference on windows?) |
|
It seems to be about different ordering when comparing two lists of IDs: https://github.com/mrc-ide/outpack-py/actions/runs/8613882705/job/23606156639#step:5:72 The LHS is always sorted alphabetically (in outpack-py/src/outpack/index.py Line 65 in 5f927d6 I've re-run the test and it passed now. I'll merge this and fix the issue separately. |
|
Fix in #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff has deprecated top-level lint settings, instead they must be moved into a dedicated
lintsection. Additionally, the CLI now needs to be invoked with achecksubcommand.https://astral.sh/blog/ruff-v0.2.0#configuration-changes
astral-sh/ruff#10169