Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to MDX v2 #164

Merged
merged 3 commits into from
May 24, 2023
Merged

feat!: upgrade to MDX v2 #164

merged 3 commits into from
May 24, 2023

Conversation

mrazauskas
Copy link
Owner

@mrazauskas mrazauskas commented May 23, 2023

Docusaurus is upgrading to MDX v2 (reference facebook/docusaurus#8288).

This plugin should support MDX v2 as well to be ready for Docusaurus v3 (facebook/docusaurus#8469).


See also the documentation PR: facebook/docusaurus#8941.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b890c75) 100.00% compared to head (e77e103) 100.00%.

❗ Current head e77e103 differs from pull request most recent head fe11c64. Consider uploading reports for the commit fe11c64 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           64        66    +2     
  Branches        21        21           
=========================================
+ Hits            64        66    +2     
Impacted Files Coverage Δ
src/plugin.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mrazauskas mrazauskas marked this pull request as ready for review May 23, 2023 09:44
@mrazauskas mrazauskas merged commit a8ecbf5 into main May 24, 2023
11 checks passed
@mrazauskas mrazauskas deleted the feat-MDX-2-suport branch May 24, 2023 05:09
@slorber
Copy link

slorber commented Oct 26, 2023

Hi

FYI Docusaurus v3 will finally be on mdx v3, a new major without many breaking changes, it should be relatively easy to make this plugin compatible

@mrazauskas
Copy link
Owner Author

Thanks for heads up.

Just gave it a try (see #210) and all tests are passing with remark-mdx v3. That was really easy (;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants