Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding subtitle support via workaround #1038

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

akazukin5151
Copy link

As noted in #331 and #964, there are no subtitles when opening videos with mpv through mpsyt. Since mpv [link] does show subtitles, the problem is likely in how mpsyt calls mpv, but I'm not sure exactly where. A temporary workaround is to add a new command, similar to the 'copy link to clipboard', except that the link goes to opening mpv directly. In the video list, typing m <number> will do mpv [link] and subtitles will now work.

This isn't the ideal solution (it imports os, check for whether mpv is installed is not implemented, no mplayer support), but there's hasn't been any progress on adding subtitle support, so this workaround might be useful for people at the meantime

@tommysolsen
Copy link
Member

If just passing the video url is enough to have it display subtitles, i guess either the way the video url is resolved and passed to the MPV player class or some flag we're setting that is hindering them from being shown correctly.

This would definitely be something that is best off being a part of the core video watching flow, as the extra functionality seemingly often gets overlooked, though if no one steps up and is willing to submit a PR fixing the issue in the main mpv player, then I'dd be happy to merge this.

Gonna leave it for a short while and see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants