Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't close the secondaryToolbar when clicking inside it (PR 18385 follow-up) #19640

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Don't close the secondaryToolbar when clicking inside it (PR 18385 follow-up) #19640

merged 1 commit into from
Mar 11, 2025
+70 −5

Conversation

Snuffleupagus
Copy link
Collaborator

When the DOM structure of the viewer was updated in PR #18385 it caused the secondaryToolbar to accidentally start closing when clicking inside of it, since the secondaryToolbar now reside under the toolbar in the DOM.

Steps to reproduce:

  • Open the viewer.
  • Open the secondaryToolbar.
  • Try to change document rotation at least twice.

Expected behaviour:
The document rotation can be changed an arbitrary number of times.

Actual results:
The secondaryToolbar closes after changing rotation just once.

@Snuffleupagus Snuffleupagus added viewer regression release-blocker Blocker for the upcoming release labels Mar 11, 2025
@Snuffleupagus Snuffleupagus changed the title Don't close the secondaryToolbar close when clicking inside it (PR 18385 follow-up) Don't close the secondaryToolbar when clicking inside it (PR 18385 follow-up) Mar 11, 2025
@Snuffleupagus Snuffleupagus force-pushed the secondaryToolbar-fix-close branch from 3ca5589 to 0acdbee Compare March 11, 2025 15:02
@mozilla mozilla deleted a comment from moz-tools-bot Mar 11, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Mar 11, 2025
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4daa7654d820b57/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/4daa7654d820b57/output.txt

Total script time: 0.89 mins

Published

@calixteman
Copy link
Contributor

Could you add an integration test please ?

@Snuffleupagus Snuffleupagus force-pushed the secondaryToolbar-fix-close branch 2 times, most recently from e7b965c to 301fa39 Compare March 11, 2025 16:22
@mozilla mozilla deleted a comment from moz-tools-bot Mar 11, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Mar 11, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Mar 11, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Mar 11, 2025
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/496f8ebdfda036e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/eb187df7c84db23/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/496f8ebdfda036e/output.txt

Total script time: 11.68 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/eb187df7c84db23/output.txt

Total script time: 27.23 mins

  • Integration Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

Could you add an integration test please ?

Sure, please see the updated patch.

calixteman
calixteman approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Don't close the secondaryToolbar when clicking inside it (PR 18385 …

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
221eba2 
…follow-up)

When the DOM structure of the viewer was updated in PR 18385 it caused the `secondaryToolbar` to accidentally start closing when clicking inside of it, since the `secondaryToolbar` now reside *under* the `toolbar` in the DOM.

**Steps to reproduce:**
 - Open the viewer.
 - Open the `secondaryToolbar`.
 - Try to change document rotation at least *twice*.

**Expected behaviour:**
 The document rotation can be changed an arbitrary number of times.

**Actual results:**
 The `secondaryToolbar` closes after changing rotation just once.
@Snuffleupagus Snuffleupagus force-pushed the secondaryToolbar-fix-close branch from 301fa39 to 221eba2 Compare March 11, 2025 18:26
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/60ae3355520e20a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/60ae3355520e20a/output.txt

Total script time: 11.72 mins

  • Integration Tests: Passed

@Snuffleupagus Snuffleupagus merged commit d746198 into mozilla:master Mar 11, 2025
7 checks passed
@Snuffleupagus Snuffleupagus deleted the secondaryToolbar-fix-close branch March 11, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman

Assignees
No one assigned
Labels
regression release-blocker Blocker for the upcoming release viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Snuffleupagus @moz-tools-bot @calixteman