Support the maxCanvasPixels option in the thumbnails code
#19635
+79
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an inconsistency in the viewer, since the thumbnails don't respect the `maxCanvasPixels` option. Note that, as far as I know, this has not lead to any bugs since the thumbnails render with a fixed (and small) width, however it really cannot hurt to address this (especially after the introduction of the `maxCanvasDim` option). To support this a new `OutputScale`-method was added, to avoid having to duplicate code in multiple files.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d75283e1fb074af/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d75283e1fb074af/output.txt Total script time: 11.61 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f92eab3a817e22f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f92eab3a817e22f/output.txt Total script time: 0.87 mins Published |
nicolo-ribaudo
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an inconsistency in the viewer, since the thumbnails don't respect the
maxCanvasPixelsoption.Note that, as far as I know, this has not lead to any bugs since the thumbnails render with a fixed (and small) width, however it really cannot hurt to address this (especially after the introduction of the
maxCanvasDimoption).To support this a new
OutputScale-method was added, to avoid having to duplicate code in multiple files./cc @nicolo-ribaudo