-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve text-selection for Type3 fonts, using d0
operators, with empty /FontBBox-entries (issue 19624)
#19625
Conversation
57108aa
to
111c00d
Compare
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/92822c84d7f3aa9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a4e950d2bb59312/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/92822c84d7f3aa9/output.txt Total script time: 2.44 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a4e950d2bb59312/output.txt Total script time: 8.13 mins
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/da6e25a2ab14186/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e5783bf64f2c9c6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/da6e25a2ab14186/output.txt Total script time: 16.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e5783bf64f2c9c6/output.txt Total script time: 29.65 mins
|
111c00d
to
7254b9a
Compare
@calixteman Gentle review ping? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
…pty /FontBBox-entries (issue 19624) For Type3 glyphs with `d1` operators it's easy to compute a fallback bounding box, however for `d0` the situation is more difficult. Given that we nowadays compute the min/max of basic path-rendering operators on the worker-thread, we can utilize that by parsing these Type3 operatorLists to guess a more suitable fallback bounding box.
7254b9a
to
0edfd29
Compare
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9ad5e971503448f/output.txt |
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f815c381bbaaff0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9ad5e971503448f/output.txt Total script time: 16.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f815c381bbaaff0/output.txt Total script time: 30.34 mins
|
For Type3 glyphs with
d1
operators it's easy to compute a fallback bounding box, however ford0
the situation is more difficult.Given that we nowadays compute the min/max of basic path-rendering operators on the worker-thread, we can utilize that by parsing these Type3 operatorLists to guess a more suitable fallback bounding box.