Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-minor] Use an icc profile for converting CMYK to RGB #19620

Merged
merged 1 commit into from
Mar 10, 2025
Merged

[api-minor] Use an icc profile for converting CMYK to RGB #19620

merged 1 commit into from
Mar 10, 2025
+224 −274

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d2ec068ec8bd11c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2281f91f2eb8adf/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d2ec068ec8bd11c/output.txt

Total script time: 16.93 mins

  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/2281f91f2eb8adf/output.txt

Total script time: 31.55 mins

  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/2281f91f2eb8adf/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

I'd expect lots of small movement all over the ref-tests with this patch, but I'd guess the explanation is that you forgot to add iccUrl in the https://github.com/mozilla/pdf.js/blob/master/test/driver.js file?

@calixteman
Copy link
Contributor Author

I'd expect lots of small movement all over the ref-tests with this patch, but I'd guess the explanation is that you forgot to add iccUrl in the https://github.com/mozilla/pdf.js/blob/master/test/driver.js file?

Yep I was expecting the same and found this oblivion almost 5 minutes ago :)

Snuffleupagus
Snuffleupagus reviewed Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a couple of quick comments, especially the CmykICCBasedCS.prototype.name field is something that I cannot tell at a glance if it's correct.

@calixteman
Copy link
Contributor Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5461d40cdcdf2ec/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/553823d17b97a77/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5461d40cdcdf2ec/output.txt

Total script time: 17.33 mins

  • Regression tests: FAILED
  different ref/snapshot: 304

Image differences available at: http://54.241.84.105:8877/5461d40cdcdf2ec/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/553823d17b97a77/output.txt

Total script time: 30.04 mins

  • Regression tests: FAILED
  different ref/snapshot: 305

Image differences available at: http://54.193.163.58:8877/553823d17b97a77/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus added the release-blocker Blocker for the upcoming release label Mar 7, 2025
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2790a5ff086c6ee/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/2790a5ff086c6ee/output.txt

Total script time: 0.89 mins

Published

@Snuffleupagus Snuffleupagus linked an issue Mar 8, 2025 that may be closed by this pull request
Broken PDF: Valve employee handbook #2218
Closed
@calixteman calixteman marked this pull request as ready for review March 10, 2025 09:16
@Snuffleupagus Snuffleupagus changed the title Use an icc profile for converting CMYK to RGB [api-minor] Use an icc profile for converting CMYK to RGB Mar 10, 2025
Snuffleupagus
Snuffleupagus approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While there's a bunch of movement in the ref-tests, this looks like an overall improvement when comparing with the rendering in Adobe Reader.

r=me, thank you.

@calixteman
Copy link
Contributor Author

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5a5df7f94586ee0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5a5df7f94586ee0/output.txt

Total script time: 17.23 mins

  • Regression tests: FAILED
  different ref/snapshot: 304

Image differences available at: http://54.241.84.105:8877/5a5df7f94586ee0/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 13474ac into mozilla:master Mar 10, 2025
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8d3d87f206b3f37/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/96f1a1b4e1b69f5/output.txt

@Snuffleupagus Snuffleupagus mentioned this pull request Mar 10, 2025
Closed
4 tasks
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8d3d87f206b3f37/output.txt

Total script time: 17.02 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/96f1a1b4e1b69f5/output.txt

Total script time: 29.90 mins

  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus mentioned this pull request Mar 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus

Assignees
No one assigned
Labels
core image-quality release-blocker Blocker for the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken PDF: Valve employee handbook
3 participants
@calixteman @moz-tools-bot @Snuffleupagus