[api-minor] Limit the maximum canvas width/height, in addition to its total area (bug 1943094) #19604
+68
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
bug-1943094
branch
from
9ef26e0 to
07718e8
Compare
Snuffleupagus
force-pushed
the
bug-1943094
branch
from
07718e8 to
39191cb
Compare
Snuffleupagus
force-pushed
the
bug-1943094
branch
from
39191cb to
9dde310
Compare
… total area (bug 1943094) Browsers not only limit the maximum total canvas area, but additionally also limit their maximum width/height which affects PDF documents with e.g. very tall and narrow pages. To address this we add a new `maxCanvasDim` viewer-option, which in Firefox will use a browser preference, such that both the total canvas area and the width/height will affect when CSS-zooming is used.
Snuffleupagus
force-pushed
the
bug-1943094
branch
from
9dde310 to
9f9de45
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cc5a8afba5b6b7a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/cc5a8afba5b6b7a/output.txt Total script time: 0.85 mins Published |
|
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/44d1c08b956899f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/44d1c08b956899f/output.txt Total script time: 11.80 mins
|
This was referenced Mar 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers not only limit the maximum total canvas area, but additionally also limit their maximum width/height which affects PDF documents with e.g. very tall and narrow pages.
To address this we add a new
maxCanvasDimviewer-option, which in Firefox will use a browser preference, such that both the total canvas area and the width/height will affect when CSS-zooming is used.