Remove ColorSpaceUtils.parseAsync and simplify the ColorSpace "API-surface"
#19599
Conversation
|
@calixteman I've been thinking about your comments the other day, and I can agree that the current "API-surface" of |
Snuffleupagus
force-pushed
the
ColorSpace-rm-parseAsync
branch
3 times, most recently
from
9d9a2a4 to
0fa01aa
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/27411087c1eebaf/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/27411087c1eebaf/output.txt Total script time: 29.79 mins
Image differences available at: http://54.241.84.105:8877/27411087c1eebaf/reftest-analyzer.html#web=eq.log |
…surface" This patch reduces the number of `ColorSpaceUtils` static-methods, and in particular the `parseAsync` method is removed and it's now instead possible to have `parse` optionally return a Promise. This thus removes the need to manually check if a `ColorSpace`-instance is cached, note the changes in the `src/core/evaluator.js` file.
Snuffleupagus
force-pushed
the
ColorSpace-rm-parseAsync
branch
from
0fa01aa to
fbf1f2b
Compare
Snuffleupagus
changed the title
ColorSpace.parseAsync and simplify the ColorSpace "API-surface"ColorSpaceUtils.parseAsync and simplify the ColorSpace "API-surface"
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c76680114c766e9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c76680114c766e9/output.txt Total script time: 16.68 mins
|
This patch reduces the number of
ColorSpaceUtilsstatic-methods, and in particular theparseAsyncmethod is removed and it's now instead possible to haveparseoptionally return a Promise.This thus removes the need to manually check if a
ColorSpace-instance is cached, note the changes in thesrc/core/evaluator.jsfile.