-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try reducing flakiness of CSS-only zoom test #19578
Conversation
c215da0
to
9980e0f
Compare
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6b51908ed4fea87/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6b51908ed4fea87/output.txt Total script time: 11.54 mins
|
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f7ffc934531201b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f7ffc934531201b/output.txt Total script time: 11.89 mins
|
(failure above is a different flaky test) |
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7dc3637f2b95e4d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7dc3637f2b95e4d/output.txt Total script time: 11.53 mins
|
Same flaky test as above (must select/unselect several editors and check copy, paste and delete operations), unrelated to the CSS-only zoom one |
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2869fdfe8248ece/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2869fdfe8248ece/output.txt Total script time: 11.96 mins
|
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7aaac6e750669d7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7aaac6e750669d7/output.txt Total script time: 11.59 mins
|
Update the test to wait for the `pagerendered`` event of a specific page (1), so that the `pagerendered`` event of other pages from a previously running render doesn't resolve the `waitForPageRendered` promise.
9980e0f
to
de9b041
Compare
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e7850338e158315/output.txt |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 1 Live output at: http://54.241.84.105:8877/be5e67d354d80ef/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0 Live output at: http://54.193.163.58:8877/afb16bf44166e87/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e7850338e158315/output.txt Total script time: 11.55 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/be5e67d354d80ef/output.txt Total script time: 11.88 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/afb16bf44166e87/output.txt Total script time: 28.69 mins
|
None of the failures above is about the CSS-only zoom test — it seems like this PR indeed fixes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
Testing if what I wrote in #19128 (comment) is correct.
The failure seems to be frequent enough that if it passes for 5 times in a row it's hopefully fixed.