Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try reducing flakiness of CSS-only zoom test #19578

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

nicolo-ribaudo
Copy link
Contributor

@nicolo-ribaudo nicolo-ribaudo commented Feb 28, 2025

Update the test to wait for the pagerendered`` event of a specific page (1), so that the pagerendered`` event of other pages from a
previously running render doesn't resolve the waitForPageRendered
promise.

Testing if what I wrote in #19128 (comment) is correct.

The failure seems to be frequent enough that if it passes for 5 times in a row it's hopefully fixed.

@nicolo-ribaudo
Copy link
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6b51908ed4fea87/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/6b51908ed4fea87/output.txt

Total script time: 11.54 mins

  • Integration Tests: Passed

@nicolo-ribaudo
Copy link
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f7ffc934531201b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/f7ffc934531201b/output.txt

Total script time: 11.89 mins

  • Integration Tests: FAILED

@nicolo-ribaudo
Copy link
Contributor Author

(failure above is a different flaky test)

@nicolo-ribaudo
Copy link
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7dc3637f2b95e4d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/7dc3637f2b95e4d/output.txt

Total script time: 11.53 mins

  • Integration Tests: FAILED

@nicolo-ribaudo
Copy link
Contributor Author

Same flaky test as above (must select/unselect several editors and check copy, paste and delete operations), unrelated to the CSS-only zoom one

@nicolo-ribaudo
Copy link
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2869fdfe8248ece/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/2869fdfe8248ece/output.txt

Total script time: 11.96 mins

  • Integration Tests: FAILED

@nicolo-ribaudo
Copy link
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7aaac6e750669d7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/7aaac6e750669d7/output.txt

Total script time: 11.59 mins

  • Integration Tests: Passed

Verified

This commit was signed with the committer’s verified signature.
fritzy Nathan Fritz
Update the test to wait for the `pagerendered`` event of a specific
page (1), so that the `pagerendered`` event of other pages from a
previously running render doesn't resolve the `waitForPageRendered`
promise.
@nicolo-ribaudo
Copy link
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e7850338e158315/output.txt

@nicolo-ribaudo
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 1

Live output at: http://54.241.84.105:8877/be5e67d354d80ef/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @nicolo-ribaudo received. Current queue size: 0

Live output at: http://54.193.163.58:8877/afb16bf44166e87/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/e7850338e158315/output.txt

Total script time: 11.55 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/be5e67d354d80ef/output.txt

Total script time: 11.88 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/afb16bf44166e87/output.txt

Total script time: 28.69 mins

  • Integration Tests: FAILED

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review March 1, 2025 23:16
@nicolo-ribaudo
Copy link
Contributor Author

None of the failures above is about the CSS-only zoom test — it seems like this PR indeed fixes it.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@Snuffleupagus Snuffleupagus merged commit 7081a1f into mozilla:master Mar 2, 2025
7 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the flaky-test branch March 2, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants