[api-minor] Re-factor how the useWorkerFetch option is used internally
#19537
Conversation
With the recently added OpenJPEG no-wasm fallback we need to send the `wasmUrl` option to the worker-thread *regardless* of the value of the `useWorkerFetch` option, since the fallback won't work if we don't have a URL to `import` it from. For consistency the code is re-factored to always send the factory-urls to the worker-thread, and simply check the `useWorkerFetch` option there instead. Also, as a follow-up to PR 19525, introduce a new `useWasm` option that can be used in e.g. browser-tests to forcibly disable WebAssembly usage.
Snuffleupagus
force-pushed
the
api-useWasm
branch
from
40639af to
641e2f5
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e78f9edd3ce2607/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c6dfd3a7c1abf8e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e78f9edd3ce2607/output.txt Total script time: 2.35 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c6dfd3a7c1abf8e/output.txt Total script time: 7.60 mins
|
|
/botio browsertest |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/41fc9d8a1bae7e9/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/158a78cc4ee1853/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/158a78cc4ee1853/output.txt Total script time: 11.74 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/41fc9d8a1bae7e9/output.txt Total script time: 28.62 mins
|
After PR 19392 we're only invoking this method *once* per document, hence the early-return branch shouldn't be necessary any more.
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4ca3ccdd208991b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c7bdb9d3b1c73a2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c7bdb9d3b1c73a2/output.txt Total script time: 17.19 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4ca3ccdd208991b/output.txt Total script time: 29.96 mins
|
With the recently added OpenJPEG no-wasm fallback we need to send the
wasmUrloption to the worker-thread regardless of the value of theuseWorkerFetchoption, since the fallback won't work if we don't have a URL toimportit from.For consistency the code is re-factored to always send the factory-urls to the worker-thread, and simply check the
useWorkerFetchoption there instead.Also, as a follow-up to PR #19525, introduce a new
useWasmoption that can be used in e.g. browser-tests to forcibly disable WebAssembly usage.