Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Add a test for copy & paste a signature editor #19534

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

calixteman
Copy link
Contributor

This patch fixes an issue when pasting: an exception was thrown when pasting. And while writing the test and comparing the paths in the svg, I found a difference which is fixed thanks to call to the right constructor (to take into account the inheritance) in inkdraw.js

Verified

This commit was signed with the committer’s verified signature.
boesing Maximilian Bösing
This patch fixes an issue when pasting: an exception was thrown when pasting.
And while writing the test and comparing the paths in the svg, I found a difference
which is fixed thanks to call to the right constructor (to take into account the inheritance)
in inkdraw.js
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 2

Live output at: http://54.241.84.105:8877/7493013e37acdae/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/6bc6c76edb1b8de/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/7493013e37acdae/output.txt

Total script time: 11.11 mins

  • Integration Tests: Passed

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/6bc6c76edb1b8de/output.txt

Total script time: 28.68 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit c2e616d into mozilla:master Feb 21, 2025
9 checks passed
@calixteman calixteman deleted the signature_description_test branch February 21, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants