Disable the loading of node types in the type tests #19531
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those type tests are performing type checking on a project using DOM APIs, intended to reflect the usage in a non-node project. Not loading the node types in that project ensures that the library type declarations don't force a dependency on the node types.
timvandermeij
approved these changes
Feb 22, 2025
|
Thanks for the fix! |
|
do you know when the next release (containing the change of Mid-January that fixed types for web projects) will happen ? Looking at the release history, it looked like a montly release happened at the beginning of each month but there was no release at the beginning of Febrary. |
|
Yes, that's because we're currently preparing a new major release; see #19536. This change will be part of that release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those type tests are performing type checking on a project using DOM APIs, intended to reflect the usage in a non-node project. Not loading the node types in that project ensures that the library type declarations don't force a dependency on the node types. See my comment in #19000 (comment)
The changes in #19341 already removed the relying on the type
import("@napi-rs/canvas").Canvas(which depends on the node types) in the types of the public API, solving the actual issue for the next release.