Move the auto-link handling into its own PDFPageView helper-method, and dispatch a "linkannotationsadded" event
#19475
+24
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
injectLinkAnnotations-method-event
branch
2 times, most recently
from
cbf46ff to
bb22144
Compare
Snuffleupagus
force-pushed
the
injectLinkAnnotations-method-event
branch
from
bb22144 to
bcb42f7
Compare
calixteman
reviewed
Feb 12, 2025
… and dispatch a "linkannotationsadded" event This is similar to a lot of existing functionality for various layers, and the new event might be helpful in e.g. the integration-tests.
Snuffleupagus
force-pushed
the
injectLinkAnnotations-method-event
branch
from
bcb42f7 to
8727a04
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f08b65a5eb82c6e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e2a8847d0913d62/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f08b65a5eb82c6e/output.txt Total script time: 10.94 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e2a8847d0913d62/output.txt Total script time: 26.56 mins
|
|
@calixteman Gentle review ping, since this is blocking another PR with auto-linking improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to a lot of existing functionality for various layers, and the new event might be helpful in e.g. the integration-tests.