Isolate the ink editor integration tests #19457
Merged
+37
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second test of the basic operations block for the ink editor depends on the first test to work. This becomes visible if we only run the second test, using `fit`, which always fails with: `ProtocolError: Waiting for selector '.annotationEditorLayer' failed: Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.` The problem is that the second test doesn't enable the ink editor and relies on the first test having done that already (because we don't close the document between tests yet). This commit fixes the issue by unconditionally enabling the ink editor in the second test to remove the dependency between the two tests so they both pass in isolation.
To avoid being able to introduce dependencies between tests, and to bring existing dependencies to the surface, this commit makes sure that we close the document between tests so that we can't accidentally rely on state set by a previous test. This prevents multiple tests from failing if one of them fails and makes debugging easier by being able to run each test on their own independent of other tests. This commit, combined with the previous one, is enough to make the ink editor integration test suite pass consistently if random mode in Jasmine is enabled, proving that the tests are fully isolated now.
timvandermeij
force-pushed
the
integration-tests-ink-isolate
branch
from
1d3099d to
6d9ff34
Compare
timvandermeij
commented
Feb 9, 2025
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/d897d4fca43f9e0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/72ab616c9137aa0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d897d4fca43f9e0/output.txt Total script time: 11.13 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/72ab616c9137aa0/output.txt Total script time: 25.79 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages contain more details about the individual changes.
Fixes a part of #19065.