-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace a couple of loops with TypedArray.prototype.fill()
#19456
Replace a couple of loops with TypedArray.prototype.fill()
#19456
Conversation
When you want to initialize a TypedArray with a non-zero value for all elements the `fill`-method is simpler than manually looping through it.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/886cbb5cf4b8af7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c8691138b3092e3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/886cbb5cf4b8af7/output.txt Total script time: 2.35 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c8691138b3092e3/output.txt Total script time: 7.52 mins
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6b83d05abc214a5/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f4602f8edeeb117/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f4602f8edeeb117/output.txt Total script time: 17.00 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/6b83d05abc214a5/output.txt Total script time: 30.16 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
When you want to initialize a TypedArray with a non-zero value for all elements the
fill
-method is simpler than manually looping through it.