Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Add the ability to print and save some newly added signatures (bug 1946795) #19437

Merged
merged 1 commit into from
Feb 9, 2025
Merged

[Editor] Add the ability to print and save some newly added signatures (bug 1946795) #19437

merged 1 commit into from
Feb 9, 2025
+790 −5

Conversation

calixteman
Copy link
Contributor

No description provided.

Snuffleupagus
Snuffleupagus approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed and passing tests; thank you.

@calixteman
[Editor] Add the ability to print and save some newly added signature…
Loading
Loading status checks…
24417a1 
…s (bug 1946795)
@calixteman calixteman force-pushed the signature_save_print1 branch from 7e0bd0a to 24417a1 Compare February 7, 2025 22:08
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7f6be5ce8e36500/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4f4c8daea0b21c2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/4f4c8daea0b21c2/output.txt

Total script time: 28.86 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7f6be5ce8e36500/output.txt

Total script time: 59.24 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman calixteman merged commit 6862e84 into mozilla:master Feb 9, 2025
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/252cfb33ac6a6cd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/29f838c33e23ef2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/252cfb33ac6a6cd/output.txt

Total script time: 16.65 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/29f838c33e23ef2/output.txt

Total script time: 29.57 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus

Assignees
No one assigned
Labels
annotations editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calixteman @moz-tools-bot @Snuffleupagus @timvandermeij