[api-minor] Add more validation for the cMapUrl, standardFontDataUrl, and wasmUrl parameters
#19416
Conversation
…rl`, and `wasmUrl` parameters Given that we now have a few different factory-url parameters, we introduce a helper function for parsing them. *Please note:* These parameters have always been documented as requiring a trailing slash[1], which we can now easily enforce during the `getDocument`-call. --- [1] I recall that we've occasionally seen issues because users miss that detail, and the new Error should hopefully be more easily actionable than one thrown during rendering/parsing.
Snuffleupagus
added
other
release-blocker
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7ca71172f7c7650/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3330f09ce2f476b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7ca71172f7c7650/output.txt Total script time: 29.04 mins
Image differences available at: http://54.241.84.105:8877/7ca71172f7c7650/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3330f09ce2f476b/output.txt Total script time: 58.27 mins
Image differences available at: http://54.193.163.58:8877/3330f09ce2f476b/reftest-analyzer.html#web=eq.log |
|
The ref-test "failures" actually look like small improvements, when comparing the images at higher zoom levels. |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4047b03873f52fe/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a09c33f69f93738/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4047b03873f52fe/output.txt Total script time: 16.64 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a09c33f69f93738/output.txt Total script time: 29.75 mins
|
Given that we now have a few different factory-url parameters, we introduce a helper function for parsing them.
Please note: These parameters have always been documented as requiring a trailing slash[1], which we can now easily enforce during the
getDocument-call.[1] I recall that we've occasionally seen issues because users miss that detail, and the new Error should hopefully be more easily actionable than one thrown during rendering/parsing.