Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add width/height getters in the AnnotationElement class #19402

Conversation

Snuffleupagus
Copy link
Collaborator

This is similar to PR #19397, but for the main-thread code, and helps to slightly shorten the code.

@mozilla mozilla deleted a comment from moz-tools-bot Feb 1, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Feb 1, 2025
@mozilla mozilla deleted a comment from moz-tools-bot Feb 1, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This is similar to PR 19397, but for the main-thread code, and helps to slightly shorten the code.
@Snuffleupagus Snuffleupagus force-pushed the AnnotationElement-width-height-getters branch from d48ffbe to 2fd1344 Compare February 1, 2025 12:20
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/03abfd7f1409c17/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f3c8f69edb46133/output.txt

@mozilla mozilla deleted a comment from moz-tools-bot Feb 1, 2025
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/03abfd7f1409c17/output.txt

Total script time: 28.85 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/f3c8f69edb46133/output.txt

Total script time: 59.34 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit de191d2 into mozilla:master Feb 1, 2025
9 checks passed
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the AnnotationElement-width-height-getters branch February 1, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants