[api-minor] Simplify the TextLayer.#getAscent fallback (PR 12896 follow-up)
#19399
+21
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/21abf56c49c8210/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7427d98c47c400b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/21abf56c49c8210/output.txt Total script time: 16.99 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7427d98c47c400b/output.txt Total script time: 30.19 mins
|
Snuffleupagus
changed the title
TextLayer.#getAscent fallback (PR 12896 follow-up)TextLayer.#getAscent fallback (PR 12896 follow-up)
…llow-up)
At the time of PR 12896 the `fontBoundingBox{Ascent, Descent}` properties were not yet available by default in Fírefox, however that's no longer the case since Firefox 116; please see https://bugzilla.mozilla.org/show_bug.cgi?id=1801198.
Hence this patch which replaces the "full" fallback with a warning and uses the `ascent`/`descent` values from the fonts in the PDF document (as we did previously). Obviously the TextLayer won't look as good in that case, but it's a simpler and shorter solution.
Snuffleupagus
force-pushed
the
TextLayer-#getAscent-simplify
branch
from
d8eaead to
c8be02f
Compare
|
@calixteman Gentle ping, any opinions about this? |
luckymore
reviewed
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of PR #12896 the
fontBoundingBox{Ascent, Descent}properties were not yet available by default in Fírefox, however that's no longer the case since Firefox 116; please see https://bugzilla.mozilla.org/show_bug.cgi?id=1801198.Hence this patch which replaces the "full" fallback with a warning and uses the
ascent/descentvalues from the fonts in the PDF document (as we did previously). Obviously the TextLayer won't look as good in that case, but it's a simpler and shorter solution.