Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a readInt16 helper function in the src/core/core_utils.js file #19388

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Snuffleupagus
Copy link
Collaborator

Rather than manually repeating code needed to get an int16, we can move and re-use an existing helper function instead.

…s` file

Rather than manually repeating code needed to get an int16, we can move and re-use an existing helper function instead.
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman
Copy link
Contributor

We should try to use DataView everywhere we can.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ffaea8113ccba41/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e402e0ae0c7705f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ffaea8113ccba41/output.txt

Total script time: 29.74 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/e402e0ae0c7705f/output.txt

Total script time: 59.30 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: Passed

@Snuffleupagus Snuffleupagus merged commit 786ac2f into mozilla:master Jan 29, 2025
9 checks passed
@Snuffleupagus Snuffleupagus deleted the readInt16 branch January 29, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants