Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-major] Change viewer component render-methods to take parameter objects #19365

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[api-major] Change viewer component render-methods to take parameter objects #19365

merged 1 commit into from
Jan 23, 2025
+83 −25

Conversation

Snuffleupagus
Copy link
Collaborator

This is nicer than a bunch of somewhat arbitrarily ordered parameters, and makes any future changes easier.

@Snuffleupagus
[api-major] Change viewer component render-methods to take paramete…
Loading
Loading status checks…
7450457 
…r objects

This is nicer than a bunch of somewhat arbitrarily ordered parameters, and makes any future changes easier.
@Snuffleupagus Snuffleupagus added viewer release-blocker Blocker for the upcoming release labels Jan 21, 2025
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8c419c621cd8b30/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/97543b115b1fdb5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8c419c621cd8b30/output.txt

Total script time: 2.33 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/97543b115b1fdb5/output.txt

Total script time: 7.46 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/80877c11c69aefd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/682a599e8d27a3e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/80877c11c69aefd/output.txt

Total script time: 10.45 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/682a599e8d27a3e/output.txt

Total script time: 27.07 mins

  • Integration Tests: FAILED

calixteman
calixteman approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 4a513bb into mozilla:master Jan 23, 2025
7 checks passed
@Snuffleupagus Snuffleupagus deleted the viewer-component-render-option-objects branch January 23, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman

Assignees
No one assigned
Labels
release-blocker Blocker for the upcoming release viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Snuffleupagus @moz-tools-bot @calixteman