Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case where openjpeg.wasm is missing #19340

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

calixteman
Copy link
Contributor

It fixes #19336.

@calixteman
Copy link
Contributor Author

I returned false in case of fetch failure because of the docs:
https://emscripten.org/docs/api_reference/module.html#Module.instantiateWasm
It seems it's better to just throw to make sure the promise is rejected.

It fixes mozilla#19336.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@Snuffleupagus
Copy link
Collaborator

/botio browsertest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5c6ab44c20a03f0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e5ea0aba19c8cbe/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/5c6ab44c20a03f0/output.txt

Total script time: 16.62 mins

  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/e5ea0aba19c8cbe/output.txt

Total script time: 30.31 mins

  • Regression tests: Passed

@Snuffleupagus Snuffleupagus merged commit 3adec37 into mozilla:master Jan 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: JPX wasm-file loading errors not handled correctly
3 participants