-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable editor when double-clicking on stamp annotation #19320
Enable editor when double-clicking on stamp annotation #19320
Conversation
8df668b
to
b5f2e75
Compare
Unfortunately the new test doesn't seem to work on the bots, since both logs contain:
|
Taking at the look at the failure, since it seems likely to be caused by my changes |
b5f2e75
to
1aa9af6
Compare
In Firefox, double-clicking on a stamp annotation triggers text selection (selecting the last text element in the dom before the annotation): this triggers the logic to make annotations not interfere with text selection, which in turns prevents the double click from triggering the annotation editor. This commit fixes the problem by making annotations non-selectable, so that clicking on them does not trigger text selection. Freetext annotations were already non-selectable, so this commit doesn't change that. However, we need to explicitly mark text in popups as selectable.
1aa9af6
to
60dd814
Compare
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1ec021137f9e021/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/753b7df4a6ab1dd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/753b7df4a6ab1dd/output.txt Total script time: 10.50 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1ec021137f9e021/output.txt Total script time: 25.87 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you.
Fixes #19315
Note that only annotations that are included in the PDF are editable by double-clicking on them. All user-created annotations are not, because they are only in the annotationEditorLayer what has
pointer-events: none
.