-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor cbindgen:ignore directives for associated functions and constants #949
Conversation
The clippy failures all seem to be in code this PR didn't touch, e.g.
Is that expected? |
0fc4584
to
e1f187e
Compare
No, not your fault. I fixed those issues in master, should be good to go. Thanks for the fix! |
if content.value().contains("XXX") { | ||
panic!("*** XXX *** {}", content.value()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! This was leftover debugging code that probably shouldn't have merged...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix here: #951
Fix for #947
Add missing checks so that cbindgen honors
cbindgen:ignore
directives for associated functions and constants declared inside a struct impl.