-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: baseline_clients_daily to only grab distribution_id for fenix app #5614
Merged
kik-kik
merged 1 commit into
main
from
fix/baseline_clients_daily-only-get-distribution_id-for-fenix
May 21, 2024
Merged
fix: baseline_clients_daily to only grab distribution_id for fenix app #5614
kik-kik
merged 1 commit into
main
from
fix/baseline_clients_daily-only-get-distribution_id-for-fenix
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
wwyc
approved these changes
May 18, 2024
sean-rose
reviewed
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the metrics_distribution_id
field you added to the org_mozilla_ios_firefox_stable.baseline_v1.schema.json
test files in #5611 be removed, since the field is only present in Fenix?
sql_generators/glean_usage/templates/baseline_clients_daily_v1.query.sql
Outdated
Show resolved
Hide resolved
kik-kik
force-pushed
the
fix/baseline_clients_daily-only-get-distribution_id-for-fenix
branch
2 times, most recently
from
May 21, 2024 10:20
fc4d5ea
to
c809303
Compare
kik-kik
force-pushed
the
fix/baseline_clients_daily-only-get-distribution_id-for-fenix
branch
from
May 21, 2024 10:21
c809303
to
01ffce0
Compare
Integration report for "fix: baseline_clients_daily to only grab distribution_id for fenix app"
|
kik-kik
deleted the
fix/baseline_clients_daily-only-get-distribution_id-for-fenix
branch
May 21, 2024 10:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: baseline_clients_daily to only grab distribution_id for fenix app
This is to address an incorrect assumption that every
baseline
ping would have the same structure. It turns out the field containing distribution_id only exists for Fenix.Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task