-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clients_last_seen_joined query and scheduler #5401
Closed
lucia-vargas-a
wants to merge
2
commits into
main
from
DENG-3475_delay_clients_last_seen_joined_and_fix_dups
Closed
Update clients_last_seen_joined query and scheduler #5401
lucia-vargas-a
wants to merge
2
commits into
main
from
DENG-3475_delay_clients_last_seen_joined_and_fix_dups
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Fix duplicates.
This comment has been minimized.
This comment has been minimized.
BenWu
approved these changes
Apr 19, 2024
@@ -15,7 +15,7 @@ scheduling: | |||
dag_name: bqetl_glean_usage | |||
task_group: {{ app_name }} | |||
depends_on_past: true | |||
date_partition_offset: -1 | |||
date_partition_offset: -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need an additional day of lag if it's only looking one day ahead?
Integration report for "One day offset."
|
Closing based on decision to revert the change that generated duplicates. See Jira task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves DENG-3475
Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task