New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image generation article #37
Add image generation article #37
Conversation
It seems that all the generated files are named "index-content.html", so update the build.sh script to reflect this. Otherwise, running build.sh will generate a bunch of new index.html files.
✅ Deploy Preview for mozilla-ai-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@johnshaughnessy can we patch up some of the styling - the rendered page looks odd. Dan can help |
Sure. I didn't added any css, so I'm guessing there are some styles added to the other pages that don't get picked up by the base template: ai-guide/templates/base-ai.html Lines 51 to 53 in 3b77912
Maybe these four inline stylesheets should be added to the base template?
|
As I've been poking around, I think I figured out that the 4 additional inline stylesheets come from the Example: 93e5c43#diff-ab61d65c3666803d258e942605930e314dd946ec56313c526f9eb276b6f5ac02R33 There are no ipynb's in my article, so those styles didn't get added. I suspect I can fix my article in any of these three ways:
I'm not sure which way is simplest. I'll think about it as I'm trying them. |
Otherwise, headerIds are disabled by default: markedjs/marked#2890 Supposedly, there is a way to to use a configuration file: marked -c .marked.json -o "${NEW_PATH%.md}-content.html" "${file}" with .marked.json: { "headerIds": true } But I could not get this working with the latest version of marked (11).
d027e45
to
e6f9b2f
Compare
Ok, I made two discoveries.
This is ready for re-review @skyfallsin . If you notice any other oddities with the styles, please let me know what they are. It took me a while to notice what you might be referring to with your previous comment. |
This PR adds an article, "Image Generation Guide".
It also modifies the build.sh script so that new articles are generated with the same name as existing articles (
index-content.html
).It also enables support for gifs in the webpack config.
It removes the call for contributions about image-models (since this is meant to be that contribution).