Skip to content

Commit

Permalink
reenable normandy-privileged (#1006)
Browse files Browse the repository at this point in the history
Largely reverts #859, but leaves out the nonexistent?
`xpi_normandy_admin` ldap group.

We have two problems: first, we had abandoned normandy-privileged
releases in-flight in production shipit, and after landing #859 we no
longer had scopes to either move forward or cancel those releases
without either reverting or reaching into the DB.

Second, we have an unexpected normandy-privileged release coming, and
there's
[pushback](mozilla-extensions/xpi-manifest#149 (comment))
against using the `privileged` format for this, even if they both use
the exact same signing format behind the scenes.

Let's reenable `normandy-privileged` and leave it enabled until it's
clear we will definitely not ship any more normandy-privileged addons.
  • Loading branch information
escapewindow committed Feb 9, 2022
1 parent 3b50c3c commit 17210ae
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
4 changes: 3 additions & 1 deletion api/src/shipit_api/admin/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
"xpi_system_signoff": XPI_SYSTEM_ADMIN_LDAP_GROUP + ADMIN_LDAP_GROUP,
"xpi_mozillaonline-privileged_signoff": XPI_MOZILLAONLINE_PRIVILEGED_LDAP_GROUP + ADMIN_LDAP_GROUP,
"xpi_mozillaonline-privileged_admin_signoff": XPI_MOZILLAONLINE_PRIVILEGED_ADMIN_LDAP_GROUP + ADMIN_LDAP_GROUP,
"xpi_normandy-privileged_signoff": ADMIN_LDAP_GROUP,
}

AUTH0_AUTH_SCOPES = dict()
Expand Down Expand Up @@ -144,14 +145,15 @@
+ LDAP_GROUPS["xpi_system_signoff"]
+ LDAP_GROUPS["xpi_mozillaonline-privileged_signoff"]
+ LDAP_GROUPS["xpi_mozillaonline-privileged_admin_signoff"]
+ LDAP_GROUPS["xpi_normandy-privileged_signoff"]
+ LDAP_GROUPS["focus-android-signoff"]
)
)
}
)

# XPI scopes
for xpi_type in ["privileged", "system", "mozillaonline-privileged"]:
for xpi_type in ["privileged", "system", "mozillaonline-privileged", "normandy-privileged"]:
# "build", "signoff", and "admin_signoff" groups can create and cancel releases
AUTH0_AUTH_SCOPES.update(
{
Expand Down
8 changes: 8 additions & 0 deletions api/src/shipit_api/common/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -530,5 +530,13 @@
},
],
},
"normandy-privileged": {
"promote": [
{"name": "Normandy privileged admin", "description": "Promote XPI", "permissions": "xpi_normandy-privileged_signoff"},
],
"ship": [
{"name": "Normandy privileged admin", "description": "Ship XPI", "permissions": "xpi_normandy-privileged_signoff"},
],
},
},
}

0 comments on commit 17210ae

Please sign in to comment.