fix: css out of order in a production build #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "sideEffects" property in package.json improves webpack treeshaking. However that causes the out-of-order CSS we were seeing in production builds. We may enable again once the bug is fixed. For more context see webpack/webpack#7094 and webpack-contrib/mini-css-extract-plugin#202.
|
@ivolimasilva can you port this to the project you are working on? |
|
Created an issue to follow up on this: #39 |
|
Reviewed and tested by @paulobmarcos in one of our internal projects. |
|
Hello Team |
|
@ebs-PriyankaKanwar Hello, do you fix your problem? |
|
In the last version, we are no longer using next-css, but instead using Next's built-in CSS support. This means there's no out-of-order errors any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "sideEffects" property in package.json improves webpack treeshaking. However that causes the out-of-order CSS we were seeing in production builds. We may enable again once the bug is fixed.
For more context see webpack/webpack#7094 and webpack-contrib/mini-css-extract-plugin#202.