feat: add webpackFetchPriority. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 17 +2
Lines 210 207 -3
Branches 73 71 -2
=========================================
- Hits 210 207 -3
☔ View full report in Codecov by Sentry. |
morganney
commented
Jun 22, 2023
| ] | ||
| }, | ||
| "test": { | ||
| "plugins": ["babel-plugin-istanbul"] |
There was a problem hiding this comment.
This is here to support coverage using jest-light-runner, which is needed to run jest outside of a vm context to prevent segmentation faults:
morganney
commented
Jun 22, 2023
| @@ -0,0 +1 @@ | |||
| node >= 12.17 | |||
morganney
commented
Jun 22, 2023
| "engines": { | ||
| "node": ">=10.3.0" | ||
| "node": ">=12.17.0" |
morganney
commented
Jun 22, 2023
Comment on lines
-13
to
-15
| if (option) { | ||
| return commentFor[key](filepath, bareImportPath, option, match) | ||
| } |
There was a problem hiding this comment.
The use of schema-utils and validating the options negates the need for this check, thereby allowing the code to be simplified.
morganney
commented
Jun 22, 2023
| additionalProperties: false | ||
| } | ||
| const schema = { | ||
| oneOf: [ | ||
| { instanceof: 'Function' }, | ||
| { instanceof: 'RegExp' }, |
There was a problem hiding this comment.
This was always intended, just overlooked.
morganney
commented
Jun 22, 2023
| @@ -57,7 +57,7 @@ const getOverrideConfig = (overrides, filepath, config) => { | |||
| } | |||
| const importPrefix = /^(?:(\.{1,2}\/)+)|^\/|^.+:\/\/\/?[.-\w]+\// | |||
| const dynamicImportsWithoutComments = | |||
| /(?<![\w.]|#!|\*[\s\w]*?|\/\/\s*|['"`][^)$]*)import\s*\((?!\s*\/\*)(?<path>\s*?['"`][^)]+['"`]\s*)\)(?!\s*?\*\/)/g | |||
| /(?<![\w.]|#!|(?:\/{2}.+\n?)+|\/\*[\s\w]*?|\*.+?|['"`][^)$,\n]*)import\s*\((?!\s*\/\*)(?<path>\s*?['"`][^)]+['"`]\s*)\)(?!\s*?\*\/)/gm | |||
There was a problem hiding this comment.
I should create a milestone outlining a transition to a JS parser like acorn.
For now, this regex has two known limitations:
- Multiline comments that are not of the JSDoc style (i.e. started with
/*and ended with*/) and include more thane one dynamic import string will be incorrectly targeted and the build will break from a syntax error. Multiline comments of the JSDoc style do not ever break the build regardless of how many import strings are present.
breaksworks/* This comment style will break the build if it spans more than one line and includes import('module') strings more than once. Like import('module2'). */
/* If you do not include more than one import('module') string, then you can have multiline comments of this style without breaking the build. */
- Strings that include a dynamic import that are not part of an embedded expression in a template literal, and preceded by a
)or,will be incorrectly targeted and the dynamic import substring will be updated with any configured comments.
breaksworksconst myString1 = '(hi)import("foo/module")(world)' // The ) in (hi) causes this string to be targeted const myString2 = '(hi,import("foo/module")(world)' // The , in (hi, causes this string to be targeted
// Inside an embedded expression things work as expected const myString1 = '(hi)${import("foo/module")}(world)' const myString2 = '(hi,${import("foo/module")}(world)'
The former case is more likely than the latter, however, both are edge cases that are probably very rare. Either way, pulling in a parser would resolve these issues for good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpackFetchPriority.dependencies, anddevDependencies.exports.