Speed up zip_broadcast()
by pre-filling the scalar elements
#740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#737 got me thinking about how to speed up
zip_broadcast()
, and one simple optimization I noticed is that there's no need to initialize thenew_item
list and fill in all the scalar values on every iteration. That only needs to be done once up front, since the loop will only ever alter the positions innew_item
associated with the iterable arguments.For the example given in #737, this new version is twice as fast as the old version:
New version:
Old version: