Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added takewhile_inclusive #736

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

OlegAlexander
Copy link
Contributor

@OlegAlexander OlegAlexander commented Jul 22, 2023

Issue reference

#730

Changes

I've added the takewhile_inclusive function and tests for it.

I ran the entire test suite and all the tests passed except for one:

======================================================================
FAIL: test_zero_limit (tests.test_more.TimeLimitedTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\github\more-itertools\tests\test_more.py", line 3919, in test_zero_limit
    self.assertEqual(actual, expected)
AssertionError: Lists differ: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12,[760707 chars]8982] != []

First list contains 108983 additional elements.
First extra element 0:
0

I wasn't sure how to fix it so I left it alone. I'm on Windows 11. Python 3.10.6.

Please let me know if you'd like me to make any changes. Thank you!

@bbayles
Copy link
Collaborator

bbayles commented Jul 26, 2023

Could you fix this flake8 error?

./tests/test_more.py:5432:80: E501 line too long (81 > 79 characters)

Thanks for the PR!

@OlegAlexander
Copy link
Contributor Author

Done.

@OlegAlexander
Copy link
Contributor Author

I saw the black 3.8 error. I formatted the code with black using the settings in your pyproject.toml file. I hope it works!

@OlegAlexander
Copy link
Contributor Author

Trying again with:

python -m black more_itertools/more.pyi -t py37 --line-length=79 -S
python -m black tests/test_more.py -t py37 --line-length=79 -S

Fingers crossed.

@bbayles bbayles merged commit 9acd6d5 into more-itertools:master Jul 27, 2023
6 checks passed
@bbayles
Copy link
Collaborator

bbayles commented Jul 27, 2023

Many thanks!

lengau pushed a commit to canonical/charmcraft that referenced this pull request Sep 12, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [more-itertools](https://togithub.com/more-itertools/more-itertools) |
`==10.0.0` -> `==10.1.0` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/more-itertools/10.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/more-itertools/10.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/more-itertools/10.0.0/10.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/more-itertools/10.0.0/10.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>more-itertools/more-itertools (more-itertools)</summary>

###
[`v10.1.0`](https://togithub.com/more-itertools/more-itertools/releases/tag/v10.1.0):
Version 10.1.0

[Compare
Source](https://togithub.com/more-itertools/more-itertools/compare/v10.0.0...v10.1.0)

##### What's Changed

- Add more tests for `zip_broadcast()` by
[@&#8203;kalekundert](https://togithub.com/kalekundert) in
[more-itertools/more-itertools#739
- Added takewhile_inclusive by
[@&#8203;OlegAlexander](https://togithub.com/OlegAlexander) in
[more-itertools/more-itertools#736
- Speed up `zip_broadcast()` by pre-filling the scalar elements by
[@&#8203;kalekundert](https://togithub.com/kalekundert) in
[more-itertools/more-itertools#740
- Added outer_product. by
[@&#8203;OlegAlexander](https://togithub.com/OlegAlexander) in
[more-itertools/more-itertools#743
- Simplify `zip_broadcast` by
[@&#8203;pochmann](https://togithub.com/pochmann) in
[more-itertools/more-itertools#742
- Simplify `_zip_equal` by
[@&#8203;pochmann](https://togithub.com/pochmann) in
[more-itertools/more-itertools#744
- fix consume() type annotation by
[@&#8203;obaltian](https://togithub.com/obaltian) in
[more-itertools/more-itertools#746
- Version 10.1.0 by [@&#8203;bbayles](https://togithub.com/bbayles) in
[more-itertools/more-itertools#747

##### New Contributors

- [@&#8203;OlegAlexander](https://togithub.com/OlegAlexander) made their
first contribution in
[more-itertools/more-itertools#736
- [@&#8203;obaltian](https://togithub.com/obaltian) made their first
contribution in
[more-itertools/more-itertools#746

**Full Changelog**:
more-itertools/more-itertools@v10.0.1...v10.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" in timezone Etc/UTC,
Automerge - "before 07:00" in timezone Etc/UTC.

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/canonical/charmcraft).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants