Add max connection age typhon server option #166
Merged
+116
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielchatfield
commented
May 5, 2023
| "http2.0-h2", | ||
|
|
||
| // The Go h2c implementation doesn't currently support max | ||
| // connection age. |
There was a problem hiding this comment.
Same as the other server options – not supported by h2c (which we don't use anywhere).
danielchatfield
changed the title
adlawson
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
typhon.ServerOptionthat will enforce a server-side maximum connection age. This is useful in environments where long-lived connections can result in unbalanced load.It's a little frustrating that I haven't been able to write a really robust test for this, I've had to settle for validating that the code is executed and the connection start time is being propagated. In practice this is a pretty decent test since the only thing it isn't covering is our ability to correctly determine if that connection start is > maxAge and to set a header which are both simple.