Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: PoC use of mocks in admin #2069

Closed
wants to merge 4 commits into from
Closed

chore: PoC use of mocks in admin #2069

wants to merge 4 commits into from

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Mar 23, 2024

Description

PoC use of mocks in admin

This PR uses this admin PR: mongodb/atlas-sdk-go#287

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@@ -23,7 +23,7 @@ require (
github.com/zclconf/go-cty v1.14.3
go.mongodb.org/atlas v0.36.0
go.mongodb.org/atlas-sdk/v20231001002 v20231001002.0.0
go.mongodb.org/atlas-sdk/v20231115008 v20231115008.0.0
go.mongodb.org/atlas-sdk/v20231115008 v20231115008.0.1-0.20240323180904-ca702fa60e32
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporal change to use the Atlas Go SDK PoC

@lantoli lantoli marked this pull request as ready for review March 25, 2024 08:24
@lantoli lantoli requested a review from a team as a code owner March 25, 2024 08:24
@lantoli lantoli closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant