Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Renames MONGODB_ATLAS_ENABLE_BETA to MONGODB_ATLAS_ENABLE_PREVIEW for features in preview #2004

Merged
merged 8 commits into from
Mar 13, 2024
Merged

refactor: Renames MONGODB_ATLAS_ENABLE_BETA to MONGODB_ATLAS_ENABLE_PREVIEW for features in preview #2004

merged 8 commits into from
Mar 13, 2024
+47 −44

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented Mar 11, 2024 •
edited
Loading

Description

Adds MONGODB_ATLAS_ENABLE_PREVIEW flag for features in preview

Link to any related issue(s): CLOUDP-223391

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Sorry, something went wrong.

@EspenAlbert EspenAlbert changed the title refactor: Renames beta -> preview refactor: Adds MONGODB_ATLAS_ENABLE_PREVIEW flag for features in preview Mar 11, 2024
@EspenAlbert EspenAlbert marked this pull request as ready for review March 11, 2024 15:48
@EspenAlbert EspenAlbert requested a review from a team as a code owner March 11, 2024 15:48
AgustinBettati
AgustinBettati approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zuhairahmed
Zuhairahmed reviewed Mar 12, 2024
View reviewed changes
@EspenAlbert EspenAlbert changed the title refactor: Adds MONGODB_ATLAS_ENABLE_PREVIEW flag for features in preview refactor: Renames MONGODB_ATLAS_ENABLE_BETA to MONGODB_ATLAS_ENABLE_PREVIEW for features in preview Mar 12, 2024
@EspenAlbert @Zuhairahmed
Update README.md
Loading
Loading status checks…
c283b62 
Co-authored-by: Zuhair Ahmed <zuhair.ahmed@mongodb.com>
maastha
maastha approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lantoli
lantoli reviewed Mar 13, 2024
View reviewed changes
.github/workflows/migration-tests.yml
@@ -265,7 +265,9 @@ jobs:
terraform_wrapper: false
- name: Migration Tests
env:
MONGODB_ATLAS_ENABLE_BETA: ${{ vars.MONGODB_ATLAS_ENABLE_BETA }}
MONGODB_ATLAS_ENABLE_PREVIEW: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knitpit: I think "true" and true are equivalent here as env vars are passed as strings

lantoli
lantoli reviewed Mar 13, 2024
View reviewed changes
.github/workflows/acceptance-tests-runner.yml
@@ -306,7 +306,7 @@ jobs:
terraform_wrapper: false
- name: Acceptance Tests
env:
MONGODB_ATLAS_ENABLE_BETA: ${{ vars.MONGODB_ATLAS_ENABLE_BETA }}
MONGODB_ATLAS_ENABLE_PREVIEW: ${{ vars.MONGODB_ATLAS_ENABLE_PREVIEW }}
Copy link
Member

@lantoli lantoli Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vars.MONGODB_ATLAS_ENABLE_PREVIEW can be replaced by true as in mig config

we need to remove all references to vars.MONGODB_ATLAS_ENABLE_PREVIEW and vars.MONGODB_ATLAS_ENABLE_BETA so they can be removed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see these changes before merging 🤦
Maybe we can clean it up in one of the test improvement PRs?

lantoli
lantoli reviewed Mar 13, 2024
View reviewed changes
.github/workflows/examples.yml
@@ -13,7 +13,7 @@ on:

env:
AWS_DEFAULT_REGION: us-west-2
MONGODB_ATLAS_ENABLE_BETA: ${{ vars.MONGODB_ATLAS_ENABLE_BETA }}
MONGODB_ATLAS_ENABLE_PREVIEW: ${{ vars.MONGODB_ATLAS_ENABLE_PREVIEW }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, vars.MONGODB_ATLAS_ENABLE_PREVIEW can be replaced by true

@EspenAlbert EspenAlbert merged commit eb20483 into master Mar 13, 2024
47 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-223391-beta-to-preview branch March 13, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantoli lantoli

@AgustinBettati AgustinBettati

@Zuhairahmed Zuhairahmed

@maastha maastha

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@EspenAlbert @lantoli @AgustinBettati @Zuhairahmed @maastha