bailey's last few comments

lint fix
mongodb · Mar 6, 2024 · 9a2a74f · 9a2a74f
1 parent 2c59205
commit 9a2a74f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/cmap/handshake/client_metadata.ts b/src/cmap/handshake/client_metadata.ts
@@ -156,18 +156,15 @@ export function makeClientMetadata(options: MakeClientMetadataOptions): ClientMe
   return metadataDocument.toObject() as ClientMetadata;
 }
 
-let isDocker: boolean;
 let dockerPromise: Promise<boolean>;
 /** @internal */
 async function getContainerMetadata() {
   const containerMetadata: Record<string, any> = {};
-  if (isDocker == null) {
-    dockerPromise ??= fs.access('/.dockerenv').then(
-      () => true,
-      () => false
-    );
-    isDocker = await dockerPromise;
-  }
+  dockerPromise ??= fs.access('/.dockerenv').then(
+    () => true,
+    () => false
+  );
+  const isDocker = await dockerPromise;
 
   const { KUBERNETES_SERVICE_HOST = '' } = process.env;
   const isKubernetes = KUBERNETES_SERVICE_HOST.length > 0 ? true : false;

diff --git a/src/connection_string.ts b/src/connection_string.ts
@@ -544,7 +544,10 @@ export function parseOptions(
   );
 
   mongoOptions.metadata = makeClientMetadata(mongoOptions);
-  mongoOptions.extendedMetadata = addContainerMetadata(mongoOptions.metadata);
+
+  mongoOptions.extendedMetadata = addContainerMetadata(mongoOptions.metadata).catch(() => {
+    /* rejections will be handled later */
+  });
 
   return mongoOptions;
 }