Add in operator to Atlas Search #1605
Merged
+371
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
katcharov
requested changes
Jan 16, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
| * @return The requested {@link SearchOperator}. | ||
| * @mongodb.atlas.manual atlas-search/in/ in operator | ||
| */ | ||
| static InSearchOperator in(final FieldSearchPath path, final ObjectId value, final ObjectId... values) { |
There was a problem hiding this comment.
I think this is based on
static DateRangeSearchOperatorBase dateRange(final FieldSearchPath path, final FieldSearchPath... paths)
Having two params ensures that the user is unable to provide zero values. I am not sure we should do this even there, but I think in this case, we should not have both of these params, but just the values, since the docs did not seem to exclude empty lists. (Note that the docs on values seem to be incorrect)
@stIncMale cc
There was a problem hiding this comment.
Let's check if the server actually allows passing value: [].
- If it does not, then following the approach taken in the rest of the search building API, we should introduce
in(final FieldSearchPath path, final ObjectId value, final ObjectId... values). We may follow that with adding another thing to be re-reviewed to JAVA-5752: Re-visit some aspects of the Atlas search API design before moving it out of beta - If the server indeed allows passing
value: [], then we should rather introducein(final FieldSearchPath path, final ObjectId... values).
There was a problem hiding this comment.
It does not allow. See https://search-playground.mongodb.com/tools/code-sandbox/snapshots/6793c3ebe68ae0bae860e843
Added comment to 5752
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Show resolved
Hide resolved
stIncMale
reviewed
Jan 16, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
stIncMale
reviewed
Jan 16, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
stIncMale
reviewed
Jan 16, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
stIncMale
requested changes
Jan 16, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
stIncMale
reviewed
Jan 16, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
stIncMale
requested changes
Jan 27, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/client/model/search/SearchOperatorTest.java
Outdated
Show resolved
Hide resolved
…rator.java Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
# Conflicts: # driver-core/src/main/com/mongodb/client/model/search/SearchConstructibleBsonElement.java # driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java # driver-core/src/test/functional/com/mongodb/client/model/search/AggregatesSearchIntegrationTest.java # driver-core/src/test/unit/com/mongodb/client/model/search/SearchOperatorTest.java # driver-scala/src/main/scala/org/mongodb/scala/model/search/SearchOperator.scala # driver-scala/src/main/scala/org/mongodb/scala/model/search/package.scala
stIncMale
requested changes
Jan 30, 2025
driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Outdated
Show resolved
Hide resolved
…rator.java Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
stIncMale
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
JAVA-5744
Description
There are several Atlas Search query operators that are not implemented with first class support in the Java driver. This PR adds the
inoperator to Atlas Search.Testing
./gradlew checkatlas-search-teston EvergreenSearchOperatorTest