Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala Client Bulk Write API. #1603

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Add Scala Client Bulk Write API. #1603

merged 7 commits into from
Jan 22, 2025

Conversation

vbabanin
Copy link
Member

JAVA-5531

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
JAVA-5531
@vbabanin vbabanin requested a review from rozza January 13, 2025 20:19
@vbabanin vbabanin marked this pull request as ready for review January 13, 2025 20:19
@vbabanin vbabanin changed the title Add Scala Bulk Write API. Add Scala Client Bulk Write API. Jan 13, 2025
JAVA-5531
@stIncMale
Copy link
Member

There are still two // TODO-JAVA-5531 in the codebase. I believe, we should address them in this PR.

JAVA-5531
@vbabanin
Copy link
Member Author

There are still two // TODO-JAVA-5531 in the codebase. I believe, we should address them in this PR.

Good catch! Removed, thanks!

@vbabanin vbabanin self-assigned this Jan 14, 2025
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - found a couple of nits and added a couple of suggestions for scala check tickets to be filed.

@@ -0,0 +1,244 @@
package org.mongodb.scala.model
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!Missing license header (this should be picked up by checkstyle if not could you open a ticket to ensure that it is in the future).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Added, thanks!

JAVA-5531
@vbabanin vbabanin requested a review from rozza January 20, 2025 02:17
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vbabanin vbabanin merged commit 089a55b into mongodb:main Jan 22, 2025
53 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants