-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scala Client Bulk Write API. #1603
Conversation
JAVA-5531
JAVA-5531
JAVA-5531
There are still two |
JAVA-5531
Good catch! Removed, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - found a couple of nits and added a couple of suggestions for scala check tickets to be filed.
@@ -0,0 +1,244 @@ | |||
package org.mongodb.scala.model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!Missing license header (this should be picked up by checkstyle if not could you open a ticket to ensure that it is in the future).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Added, thanks!
driver-scala/src/main/scala/org/mongodb/scala/model/bulk/package.scala
Outdated
Show resolved
Hide resolved
JAVA-5531
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
JAVA-5531