Fix onErrorDropped logged message (#1281)
#1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by using `doOnError` rather than using `subscribe` and passing the handler in there. JAVA-5284 JAVA-5266
rozza
requested review from
a team and
stIncMale
and removed request for
a team
stIncMale
reviewed
Jan 5, 2024
There was a problem hiding this comment.
I was confused by the PR name, because I understand backporting as cherry-picking something into the branch for an older major/minor version (e.g., from master to 4.11.x). Now I see that this is effectively a cherry-pick of #1281 from the CSOT branch.
- Could we not name the commit "backport"?
- Why do we need to cherry-pick this change from
CSOTtomaster? Is it because we want the fix to be released in 5.0 before CSOT is done?
Sure we can
We don't need to cherry-pick it but it is a fix for a bug that exists in master. The reason to backport it from the CSOT branch into master is because all changes from CSOT will be squashed into a single mega commit. This loses any history of certain changes that were found during CSOT but dont necessarily pertain to CSOT. |
rozza
changed the title
onErrorDropped logged message (#1281)onErrorDropped logged message (#1281)
stIncMale
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by using
doOnErrorrather than usingsubscribeand passing the handler in there.JAVA-5284 JAVA-5266