Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DatabaseTestCase to Junit 5 #1238

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Update DatabaseTestCase to Junit 5 #1238

merged 3 commits into from
Oct 31, 2023

Conversation

rozza
Copy link
Member

@rozza rozza commented Oct 31, 2023

@rozza rozza requested a review from stIncMale October 31, 2023 12:45
@rozza
Copy link
Member Author

rozza commented Oct 31, 2023

I opted to leave driver-legacy code as that has more substantive changes - lots of use of assumeThat with hamcrest matchers, which don't directly port to Junit5

jyemin
jyemin approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional change request, but LGTM.

...e-streams/src/test/functional/com/mongodb/reactivestreams/client/TransactionFailureTest.java Outdated Show resolved Hide resolved
@jyemin jyemin removed the request for review from stIncMale October 31, 2023 13:07
@rozza rozza merged commit 8043b35 into mongodb:master Oct 31, 2023
56 checks passed
@rozza rozza deleted the JAVA-5220 branch October 31, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rozza @jyemin