Enable container and Kubernetes awareness for improved telemetry. #1235
+168
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-5210
JAVA-5210
JAVA-5210
vbabanin
commented
Oct 27, 2023
| @@ -257,6 +257,7 @@ configure(javaCodeCheckedProjects) { | |||
| testImplementation 'org.spockframework:spock-core' | |||
| testImplementation 'org.spockframework:spock-junit4' | |||
| testImplementation("org.mockito:mockito-core:3.8.0") | |||
| testImplementation("org.mockito:mockito-inline:3.8.0") | |||
There was a problem hiding this comment.
This useful addon to Mockito allows for the mocking of static methods.
vbabanin
commented
Oct 27, 2023
| @@ -168,8 +180,7 @@ static boolean clientMetadataDocumentTooLarge(final BsonDocument document) { | |||
| new BsonDocumentCodec().encode(new BsonBinaryWriter(buffer), document, EncoderContext.builder().build()); | |||
| return buffer.getPosition() > MAXIMUM_CLIENT_METADATA_ENCODED_SIZE; | |||
| } | |||
|
|
|||
| private enum Environment { | |||
| private enum FaasEnvironment { | |||
There was a problem hiding this comment.
With the introduction of new parameters in the env section related to containers/orchestration, I've renamed this enum in accordance with the specification, as it contains metadata of FaaS environment.
JAVA-5210
JAVA-5210
rozza
approved these changes
Oct 30, 2023
| @@ -168,8 +180,7 @@ static boolean clientMetadataDocumentTooLarge(final BsonDocument document) { | |||
| new BsonDocumentCodec().encode(new BsonBinaryWriter(buffer), document, EncoderContext.builder().build()); | |||
| return buffer.getPosition() > MAXIMUM_CLIENT_METADATA_ENCODED_SIZE; | |||
| } | |||
|
|
|||
| private enum Environment { | |||
| private enum FaasEnvironment { | |||
| @@ -257,6 +257,7 @@ configure(javaCodeCheckedProjects) { | |||
| testImplementation 'org.spockframework:spock-core' | |||
| testImplementation 'org.spockframework:spock-junit4' | |||
| testImplementation("org.mockito:mockito-core:3.8.0") | |||
| testImplementation("org.mockito:mockito-inline:3.8.0") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include container and Kubernetes awareness, as specified in the MongoDB Handshake Specification
JAVA-5072