Handle interrupts: Socket.connect is interruptible in a virtual thread
#1203
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
approved these changes
Sep 26, 2023
| @@ -79,7 +82,9 @@ public void open() { | |||
| inputStream = socket.getInputStream(); | |||
| } catch (IOException e) { | |||
| close(); | |||
| throw new MongoSocketOpenException("Exception opening socket", getAddress(), e); | |||
There was a problem hiding this comment.
I think it's worth a ticket to make this consistent with read/write methods to throw IOException and do the exception transation in InternalStreamConnection. It can be dependent on the ticket to remove Stream from the API.
There was a problem hiding this comment.
vbabanin
reviewed
Sep 29, 2023
driver-core/src/main/com/mongodb/internal/connection/SocketStream.java
Outdated
Show resolved
Hide resolved
vbabanin
approved these changes
Sep 29, 2023
JAVA-5138
stIncMale
added a commit
to stIncMale/mongo-java-driver
that referenced
this pull request
Sep 29, 2023
JAVA-5138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably,
Socket.closemay also block if one enablesSO_LINGERby callingSocket.setSoLinger, yet there is not a word on interruptibility ofSocket.closein the docs. Fortunately, we don't enableSO_LINGER, so we don't have to care about the behavior ofSocket.close.JAVA-5138