Scale double values to 4 decimal digits in geoNear test #1197
+39
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around small variations in native math libraries used by the server. JAVA-5097
katcharov
reviewed
Sep 13, 2023
| final int scale, final RoundingMode roundingMode) { | ||
| List<BsonDocument> expectedResults = parseToList(expectedResultsAsString); | ||
| List<BsonDocument> results = getCollectionHelper().aggregate(pipeline); | ||
| assertEquals(adjustScale(expectedResults, scale, roundingMode), adjustScale(results, scale, roundingMode)); |
There was a problem hiding this comment.
Looks good. Another option would have been to perform recursive equality, with an epsilon on floating points. But I don't think we'll have an issue in these tests since the decimal places aren't close to being 0 (which would make the flooring flaky).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around small variations in native math libraries used by the server.
JAVA-5097