Handle new explain output in tests #1191
Merged
+29
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response document for the explain command has changed in 7.2 sharded clusters. It introduces a top-level "shards" document that contains the explain output for each shard. This patch supports this new field in tests of explain API in the driver. JAVA-5137
katcharov
approved these changes
Sep 11, 2023
| @@ -99,27 +99,48 @@ public void testExplainOfAggregateWithNewResponseStructure() { | |||
| AggregateIterable<BsonDocument> iterable = collection | |||
| .aggregate(singletonList(Aggregates.match(Filters.eq("_id", 1)))); | |||
|
|
|||
| Document explainDocument = iterable.explain(); | |||
| assertNotNull(explainDocument); | |||
| Document explainDocument = getAggregateExplainDocument(iterable.explain()); | |||
There was a problem hiding this comment.
There's an explanatory comment related to such a structure change at the top of this method, should it be updated / removed?
There was a problem hiding this comment.
Good idea. That's not quite the place for it (since it's about skipping the tests) but I added a note above the new helper method instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response document for the explain command has changed in 7.2 sharded clusters. It introduces a top-level "shards" document that contains the explain output for each shard. This patch supports this new field in tests of explain API in the driver.
JAVA-5137