Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FaaS (AWS Lambda) test app #1183

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

katcharov
Copy link
Contributor

JAVA-4758

Modified evergreen project variables, as per above Jira.

Comment on lines 114 to 118
.append("totalCommandDuration", new BsonDouble(totalCommandDuration))
.append("totalCommandCount", new BsonDouble(totalCommandCount))
.append("totalHeartbeatDuration", new BsonDouble(totalHeartbeatDuration))
.append("totalHeartbeatCount", new BsonDouble(totalHeartbeatCount))
.append("openConnections", new BsonDouble(openConnections));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note possible differences in naming vs other drivers. Happy to change to match (though perhaps in that case the spec could specify these exactly.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think the exact naming is important as we aren't asserting anything.

@durran
Copy link
Member

durran commented Aug 21, 2023

@katcharov Do you have a patch build showing this running in evergreen? I don't see the variant in the evergreen PR run. (But the evergreen changes appear like they should be working)

@katcharov
Copy link
Contributor Author

@durran I think this should be it: https://spruce.mongodb.com/task/mongo_java_driver_rhel8_test_atlas_test_aws_lambda_deployed_patch_18cb29924b0434efbfcb288e304a8059072d3684_64e3995e32f417c8e241be77_23_08_21_17_05_35/logs?execution=0

[2023/08/21 17:24:29.075] {"statusCode":200,"headers":{"X-Custom-Header":"application/json","Content-Type":"application/json"},"body":"{\"totalCommandDuration\": 214.0, \"totalCommandCount\": 4.0, \"totalHeartbeatDuration\": 184068.0, \"totalHeartbeatCount\": 18.0, \"openConnections\": 1.0}"}START RequestId: 79bb53a8-b024-4f02-83db-66272fea225d Version: $LATEST
[2023/08/21 17:24:29.075] END RequestId: 79bb53a8-b024-4f02-83db-66272fea225d

3 instances of stats being emitted like this. (If the missing variant should be there, please let me know, and I will try to make sure it's added. I believe test_atlas_task_group is new as of this PR.)

@stIncMale
Copy link
Member

I think this should be it

@katcharov Just reconfigure the patch submitted as a result of pushing to the commit branch, such that it runs the tasks that were introduced in this PR (you can access the patch through the Evergreen "Details" link in the list of GitHub checks). That's where reviewers are naturally expecting to see the results of the tasks relevant to the PR.

Note that with each new commit pushed you'll need to reconfigure that patch. It is still better than submitting a separate patch and then linking it again each time you add a new commit to the PR.

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration side looks good to me. I won't comment on Java specific items.

@jyemin jyemin requested review from rozza and removed request for stIncMale August 22, 2023 13:06
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of gradle related changes

Comment on lines +2069 to +2073
- name: rhel8-test-atlas
display_name: Atlas Cluster Tests
run_on: rhel80-large
tasks:
- test_atlas_task_group
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rozza Should this run when a commit is merged into master, and if so, where could I set that up? (I did not see anything definite in the project settings.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question!

Evergreen monitors a set of github repositories, waiting for new commits. When a new commit comes in or enough time has passed, Evergreen schedules builds for different variants (different OSes, compile flags, etc). [1]

So as the evergreen project monitors the master branch, all build variants will run by default.

See limiting when a task will run to learn about opting out. One such example is the publish release task which opts out by setting git_tag_only: true.

Our evg.yml dates back from early evergreen days - I find it hard to grok and I wonder if there are newer features that we don't use. (a thought for another day).

@katcharov katcharov requested a review from rozza August 22, 2023 17:50
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm a patch has successfully run against the latest changes, then I'll LGTM.

@katcharov
Copy link
Contributor Author

@rozza test-aws-lambda-deployed passed. The remaining failures, I believe, would be fixed in master.

@katcharov katcharov requested a review from rozza September 15, 2023 14:38
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katcharov katcharov merged commit e477257 into mongodb:master Sep 20, 2023
@katcharov katcharov deleted the JAVA-4758 branch September 20, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants