Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evergreen: Updated static checks #1172

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Evergreen: Updated static checks #1172

merged 1 commit into from
Aug 10, 2023
+32 −9

Conversation

rozza
Copy link
Member

@rozza rozza commented Aug 9, 2023 •
edited
Loading

Ensures that Kotlin and Scala checks are also run.

  • Renamed compile.sh to static-checks.sh so its discoverable
  • Added compileIntegrationTest to Kotlin/Scala checks
  • Updated the evergreen static-checks.sh to run the Kotlin & Scala checks

JAVA-5095

@rozza rozza closed this Aug 9, 2023
@rozza rozza reopened this Aug 9, 2023
@rozza rozza closed this Aug 9, 2023
@rozza rozza reopened this Aug 9, 2023
@rozza
Evergreen: Updated static checks
05448a3 
Ensures that Kotlin and Scala checks are also run
JAVA-5095
@rozza
Copy link
Member Author

rozza commented Aug 9, 2023

Only needs a single LGTM - so first reviewer wins.

katcharov
katcharov approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like the new scalaCheck basically copies the kotlinCheck.

@rozza rozza merged commit a7abd05 into mongodb:master Aug 10, 2023
@rozza rozza deleted the JAVA-5095 branch August 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katcharov katcharov

@stIncMale stIncMale

@vbabanin vbabanin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rozza @katcharov