Add TimePoint and use it in Timeout
#1164
Merged
+382
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stIncMale
force-pushed
the
JAVA-5076_add_Timer
branch
3 times, most recently
from
688fc75 to
9551a75
Compare
stIncMale
force-pushed
the
JAVA-5076_add_Timer
branch
3 times, most recently
from
5058526 to
6586344
Compare
JAVA-5076
stIncMale
force-pushed
the
JAVA-5076_add_Timer
branch
from
6586344 to
807d185
Compare
stIncMale
commented
Aug 4, 2023
stIncMale
commented
Aug 4, 2023
| * <hr> | ||
| * <sup>(*)</sup> n is positive and odd. | ||
| */ | ||
| private long elapsedNanos(final long currentNanos) { |
There was a problem hiding this comment.
This method went to Timer.
It's no longer needed because of mongodb/specifications@31f29fb JAVA-5076
katcharov
requested changes
Aug 9, 2023
stIncMale
changed the title
Timer and use it in TimeoutTimePoint and use it in Timeout
JAVA-5105
Instead of having an assertion in `TimePoint` that may detect when a monotonic timer jumps back in time (the OS implementations of monotonic timers are notorious for having bugs, but there is nothing we can do with that), we better allow measuring passing both earlier and later points in `durationSince`. JAVA-5105
JAVA-5105
JAVA-5105
katcharov
approved these changes
Aug 18, 2023
JAVA-5105
JAVA-5105
JAVA-5105
vbabanin
reviewed
Aug 21, 2023
| long elapsedNanos = elapsedNanos(currentNanos); | ||
| return elapsedNanos < 0 ? 0 : Math.max(0, durationNanos - elapsedNanos); | ||
| long remainingNanos(final TimePoint now) { | ||
| return Math.max(0, durationNanos - now.durationSince(assertNotNull(start)).toNanos()); |
There was a problem hiding this comment.
[Optional] According to the javadoc in TimePoint, we can replace TimePoint.now().durationSince(this) with the method elapsed() to avoid passing a parameter down function.
@VisibleForTesting(otherwise = PRIVATE)
long remainingNanos() {
return Math.max(0, durationNanos - assertNotNull(start).elapsed().toNanos());
}
There was a problem hiding this comment.
The whole point of exposing remainingNanos for tests is so that tests could pass an arbitrary "now". If this were not needed, remainingNanos would not have been extracted from remaining. With elapsed, using an arbitrary "now" is impossible.
vbabanin
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces internal API needed for JAVA-5076 (see #1166). I separated the change in this PR to make #1166 more focused on business logic.
The internal API introduced in the PR is intended to solve the following problems:
System.nanoTimeis such a tool, but it would have been better to have a tool that exposes types less generic thanlong, and values that are meaningful on their own (a value returned bySystem.nanoTimeis meaningless on its own).Timeoutwas started at.